Add missing expansion patterns for math.powf
#14614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the same approach as for other math ops. This will prevent the powf operation to be scalaried on CPU.
dcaballe
requested review from
rsuderman and
MaheshRavishankar
and removed request for
MaheshRavishankar
dcaballe
commented
Aug 9, 2023
| @@ -30,6 +30,7 @@ class PolynomialApproximationPass | |||
| RewritePatternSet mathPatterns(&getContext()); | |||
| populateExpandTanPattern(mathPatterns); | |||
| populateExpandExp2FPattern(mathPatterns); | |||
| populateExpandPowFPattern(mathPatterns); | |||
There was a problem hiding this comment.
It's not clear to me what qualifies the expansions to be here or in the if-else statement below... but this should be similar to Exp2
There was a problem hiding this comment.
IIUC, it should be inside if-then-else if you are worried the approximation is not precise enough. As far as I know, if exp2 is precise enough then this shouldn't cause a huge issue.
|
Looks good, but waiting for benchmark runs |
bviyer
approved these changes
Aug 11, 2023
| @@ -30,6 +30,7 @@ class PolynomialApproximationPass | |||
| RewritePatternSet mathPatterns(&getContext()); | |||
| populateExpandTanPattern(mathPatterns); | |||
| populateExpandExp2FPattern(mathPatterns); | |||
| populateExpandPowFPattern(mathPatterns); | |||
There was a problem hiding this comment.
IIUC, it should be inside if-then-else if you are worried the approximation is not precise enough. As far as I know, if exp2 is precise enough then this shouldn't cause a huge issue.
jinchen62
pushed a commit
to jinchen62/iree
that referenced
this pull request
Sep 18, 2023
Following the same approach as for other math ops. This will prevent the powf operation to be scalarized on CPU. Fixes iree-org#13547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same approach as for other math ops. This will prevent the powf operation to be scalarized on CPU.
Fixes #13547