-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pass to decompose batch_mmt4d ops into mmt4d #14628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
force-pushed
the
batch-mmt4d-decompose
branch
from
August 10, 2023 21:26
62eb5ff
to
3e2b92e
Compare
pzread
changed the title
[WIP] Add LLVMCPUDecomposeBatchMmt4D pass
[WIP] Add DecomposeBatchMmt4DOps pass
Aug 10, 2023
pzread
force-pushed
the
batch-mmt4d-decompose
branch
3 times, most recently
from
August 10, 2023 23:01
a8873a0
to
c1db2b2
Compare
pzread
changed the title
[WIP] Add DecomposeBatchMmt4DOps pass
[WIP] Add pass to decompose batch_mmt4d ops into mmt4d
Aug 10, 2023
pzread
force-pushed
the
batch-mmt4d-decompose
branch
2 times, most recently
from
August 10, 2023 23:23
407cd65
to
94ddb87
Compare
pzread
force-pushed
the
batch-mmt4d-decompose
branch
from
August 11, 2023 16:53
94ddb87
to
48c9570
Compare
pzread
changed the title
[WIP] Add pass to decompose batch_mmt4d ops into mmt4d
Add pass to decompose batch_mmt4d ops into mmt4d
Aug 11, 2023
MaheshRavishankar
requested changes
Aug 11, 2023
compiler/src/iree/compiler/Codegen/Common/DecomposeBatchMmt4DOps.cpp
Outdated
Show resolved
Hide resolved
MaheshRavishankar
approved these changes
Aug 11, 2023
pzread
force-pushed
the
batch-mmt4d-decompose
branch
from
August 11, 2023 21:01
f543953
to
8eb9a82
Compare
pzread
force-pushed
the
batch-mmt4d-decompose
branch
from
August 11, 2023 21:15
8eb9a82
to
affc000
Compare
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pass to decompose
batch_mmt4d
intommt4d
by:Once
batch_mmt4d
is converted intommt4d
, we can reuse the ukernel path in the later codegen pipeline. The goal is to provide a path ofbatch_matmul -> batch_mmt4d -> mmt4d -> ukernel
Related issue: #14431