Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pass to decompose batch_mmt4d ops into mmt4d #14628

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

pzread
Copy link
Contributor

@pzread pzread commented Aug 10, 2023

Add a pass to decompose batch_mmt4d into mmt4d by:

  1. Tiling the batch dim to 1
  2. Drop the unit batch dims on LHS, RHS, and the result
  3. Replace the batch_mmt4d with mmt4d

Once batch_mmt4d is converted into mmt4d, we can reuse the ukernel path in the later codegen pipeline. The goal is to provide a path of batch_matmul -> batch_mmt4d -> mmt4d -> ukernel

Related issue: #14431

@pzread pzread changed the title [WIP] Add LLVMCPUDecomposeBatchMmt4D pass [WIP] Add DecomposeBatchMmt4DOps pass Aug 10, 2023
@pzread pzread force-pushed the batch-mmt4d-decompose branch 3 times, most recently from a8873a0 to c1db2b2 Compare August 10, 2023 23:01
@pzread pzread changed the title [WIP] Add DecomposeBatchMmt4DOps pass [WIP] Add pass to decompose batch_mmt4d ops into mmt4d Aug 10, 2023
@pzread pzread force-pushed the batch-mmt4d-decompose branch 2 times, most recently from 407cd65 to 94ddb87 Compare August 10, 2023 23:23
@pzread pzread changed the title [WIP] Add pass to decompose batch_mmt4d ops into mmt4d Add pass to decompose batch_mmt4d ops into mmt4d Aug 11, 2023
@pzread pzread marked this pull request as ready for review August 11, 2023 17:13
@pzread pzread requested a review from hanhanW August 11, 2023 17:13
@pzread pzread enabled auto-merge (squash) August 11, 2023 21:15
@pzread pzread merged commit dca2f1f into iree-org:main Aug 11, 2023
50 checks passed
nhasabni pushed a commit to plaidml/iree that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants