Patch over some TensorFlow Python API changes. #14709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
the
integrations/tensorflow
ScottTodd
commented
Aug 16, 2023
| with open(tf_iree_input, "r") as f: | ||
| with open(tf_iree_input, "rb") as f: |
There was a problem hiding this comment.
Colab notebooks should also be updated to handle bytecode, such as here: https://github.com/openxla/iree/blob/fb38d2092cefa8aca53b1ed67c35829cb039b06b/samples/variables_and_state/variables_and_state.ipynb#L185-L198
This code will read a bytecode file and print it as text:
from iree.compiler import ir
module = ir.Module.parse(module_mlir_bytecode, ir.Context())
module.dump()There was a problem hiding this comment.
#14743 also added a command to ir_tool that can do this.
There was a problem hiding this comment.
Updating notebooks in #14901
|
ping @jpienaar (welcome back :D) |
|
Synced. Ping again, @jpienaar ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards getting our sample Colab notebooks working again (https://github.com/openxla/iree/actions/workflows/samples.yml). I could try to update the Colab notebooks in-place, but it might just be easier to take an incremental approach - land these fixes that help with local builds, wait for a nightly release, debug the notebooks with that release build.
We're also short on presubmit / unit test coverage for the Python tools.
Resolves this discussion: #14303 (comment)
Fixes #14695