Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch over some TensorFlow Python API changes. #14709

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

ScottTodd
Copy link
Member

Working towards getting our sample Colab notebooks working again (https://github.com/openxla/iree/actions/workflows/samples.yml). I could try to update the Colab notebooks in-place, but it might just be easier to take an incremental approach - land these fixes that help with local builds, wait for a nightly release, debug the notebooks with that release build.

We're also short on presubmit / unit test coverage for the Python tools.

Resolves this discussion: #14303 (comment)
Fixes #14695

@ScottTodd ScottTodd added the integrations/tensorflow TensorFlow model import and conversion label Aug 16, 2023
with open(tf_iree_input, "r") as f:
with open(tf_iree_input, "rb") as f:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colab notebooks should also be updated to handle bytecode, such as here: https://github.com/openxla/iree/blob/fb38d2092cefa8aca53b1ed67c35829cb039b06b/samples/variables_and_state/variables_and_state.ipynb#L185-L198

This code will read a bytecode file and print it as text:

from iree.compiler import ir

module = ir.Module.parse(module_mlir_bytecode, ir.Context())
module.dump()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14743 also added a command to ir_tool that can do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating notebooks in #14901

@ScottTodd
Copy link
Member Author

ping @jpienaar (welcome back :D)

@ScottTodd
Copy link
Member Author

Synced. Ping again, @jpienaar ?

Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping

@ScottTodd ScottTodd merged commit c1e116b into iree-org:main Aug 30, 2023
54 checks passed
@ScottTodd ScottTodd deleted the tensorflow-arghhhh branch August 30, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations/tensorflow TensorFlow model import and conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xef in position 2: invalid continuation byte
2 participants