[HAL] Add a pass to materialize homogeneous encodings. #14724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hanhanW
commented
Aug 17, 2023
•
hanhanW
commented
- Adds buildMaterializeEncodingsPassPipeline method to TargetBackend. In this revision, only llvm-cpu backend implements the method.
- Adds buildMaterializeEncodingsPassPipeline method to TargetBackend. In this revision, only llvm-cpu backend implements the method. - Updates CPU upper_bound_tile_size materialization be only accepting single executable target.
benvanik
requested changes
Aug 22, 2023
There was a problem hiding this comment.
I don't understand what this is for - you're running a pass on the host module that should have nothing you can change - no linalg ops, no tensors, no nothing - at the head of the HAL pipeline where this is running there should only be hal.executables, and the next pass to run is translate executables and that lets you run your backend-specific passes on your backend-specific IR.
|
I moved the pass to GlobalOptimization phase, so it no longer needs to update HAL things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.