[Flow] Raise special linalg.generic ops to linalg.fill ops
#14773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
force-pushed
the
raise_generics_to_fills
branch
from
834441a
to
9211662
Compare
MaheshRavishankar
requested changes
Aug 22, 2023
| Value yieldOperand; | ||
| for (Operation &bodyOp : linalgOp.getBlock()->getOperations()) { | ||
| if (isa<linalg::YieldOp>(bodyOp)) | ||
| yieldOperand = bodyOp.getOperand(0); |
There was a problem hiding this comment.
You also need to check that the yield operand is not the basic block argument of the linalg operation itself.
There was a problem hiding this comment.
Should be good now. Lmk what you think.
Max191
force-pushed
the
raise_generics_to_fills
branch
2 times, most recently
from
a02ba09
to
2281e94
Compare
MaheshRavishankar
approved these changes
Aug 23, 2023
| // Check that the op body is only a linalg.yield op. | ||
| Value yieldOperand; | ||
| for (Operation &bodyOp : linalgOp.getBlock()->getOperations()) { | ||
| if (isa<linalg::YieldOp>(bodyOp)) |
There was a problem hiding this comment.
Nit: please add { around all statements (this is divergence in IREE style w.r.t LLVM style)
| // Check that the operand of the linalg.yield op is not an argument of the | ||
| // linalg.generic basic block | ||
| for (Value blockArg : linalgOp.getBlock()->getArguments()) | ||
| if (yieldOperand == blockArg) |
There was a problem hiding this comment.
Same nit here. Please add braces always in IREE.
Max191
force-pushed
the
raise_generics_to_fills
branch
2 times, most recently
from
c720f45
to
a488f29
Compare
|
rebased on top of main |
Max191
force-pushed
the
raise_generics_to_fills
branch
from
a488f29
to
892148d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.