Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump python to 3.9 and tf-nightly to 2.15.0.dev20230824 #14810

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Bump python to 3.9 and tf-nightly to 2.15.0.dev20230824 #14810

merged 5 commits into from
Aug 25, 2023

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Aug 25, 2023 •
edited
Loading

Fixes #14775

@hanhanW hanhanW added benchmarks:cuda Run default CUDA benchmarks benchmarks:x86_64 Run default x86_64 benchmarks benchmarks:comp-stats Run default compilation statistics benchmarks benchmarks:android-cpu Run default Android CPU benchmarks benchmarks:android-gpu Run default Android GPU benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU labels Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Abbreviated Benchmark Summary

@ commit 657833a06609d262e8d15e2a2f4c05627978dde5 (no previous benchmark results to compare)

Raw Latencies

Benchmark Name Average Latency (ms) Median Latency (ms) Latency Standard Deviation (ms)
DeepLabV3\_fp32(tflite) [armv8.2-a-generic-linux\_android29-llvm\_cpu][default-flags] local\_sync(embedded\_elf)[full-inference,default-flags] with zeros @ pixel-4[big-core] 74.349 74.335 0.057
DeepLabV3\_fp32(tflite) [armv8.2-a-generic-linux\_android29-llvm\_cpu][default-flags] local\_sync(embedded\_elf)[full-inference,default-flags] with zeros @ pixel-4[little-core] 404.246 404.068 1.343
DeepLabV3\_fp32(tflite) [armv8.2-a-generic-linux\_android29-llvm\_cpu][default-flags] local\_task(embedded\_elf)[1-thread,full-inference,system-scheduling] with zeros @ pixel-4[big-core] 62.325 62.311 0.064

[Top 3 out of 261 results showed]

No improved or regressed compilation metrics 🏖️

For more information:

Source Workflow Run

hcindyl
hcindyl reviewed Aug 25, 2023
View reviewed changes
integrations/tensorflow/test/iree_tfl_tests/llvmcpu_mobilenet_v3-large_uint8.run Outdated
@@ -1,2 +1,4 @@
# REQUIRES: llvmcpu
# RUN: %PYTHON -m iree_tfl_tests.mobilenet_v3-large_uint8_test --target_backend=llvmcpu --artifacts_dir=%t
# TODO(#14775): Enable the test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file a different issue for this failure? Since the PR marks #14775 as fixed, we might lose track of the test being disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should. This is mainly for testing. I will file an issue for this. There is a correctness issue.

Copy link
Contributor

@hcindyl hcindyl Aug 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... it seems to be an outstanding failure. The first occurrence was on tf-nightly==2.15.0.dev20230803 and iree-samples daily regression tests have been failing since https://github.com/iree-org/iree-samples/actions/runs/5752383899.

https://github.com/iree-org/iree-samples/actions/workflows/regression_tests.yml?page=2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #14830 filed

@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 25, 2023

@pzread @ScottTodd @stellaraccident please take a look if it is okay to bump python version to 3.9. This is required by tf-nightly package: https://pypi.org/project/tf-nightly/

image

@ScottTodd
Copy link
Member

@pzread @ScottTodd @stellaraccident please take a look if it is okay to bump python version to 3.9. This is required by tf-nightly package: https://pypi.org/project/tf-nightly/

image

We have a few other parts of the project that refer to Python 3.8 that we could update, e.g. https://github.com/openxla/iree/blob/85a5425cc8c0b5c4c1db2aa1e242df604bf340ff/compiler/setup.py#L426

I think that can happen in a future cleanup PR though.

@hanhanW hanhanW marked this pull request as ready for review August 25, 2023 18:17
@hanhanW hanhanW enabled auto-merge (squash) August 25, 2023 18:31
@hanhanW hanhanW mentioned this pull request Aug 25, 2023
Merged
@hanhanW hanhanW merged commit 7d7391f into iree-org:main Aug 25, 2023
58 checks passed
@hanhanW hanhanW deleted the bump-tf-nightly branch August 25, 2023 19:52
@stellaraccident
Copy link
Collaborator

If it were me, I would bump to 3.11 or 3.10. I see no value in the old versions for where we are. But if you are doing the work, I'm not going to push back.

@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 25, 2023

If it were me, I would bump to 3.11 or 3.10. I see no value in the old versions for where we are. But if you are doing the work, I'm not going to push back.

I mainly wanna re-enable benchmark suites because I need them to evaluate some of patches, so I just picked a working version. I'm not going to touch this part. Feel free to bump it to 3.10 or 3.11 if it is better.

@hcindyl
Copy link
Contributor

hcindyl commented Aug 25, 2023

if we want to bump to 3.10 or 3.11, the base docker needs to be bumped from ubuntu 20.04 to ubuntu 22.04 -- the highest python 3 for ubuntu 20.04 is 3.9

https://packages.ubuntu.com/search?keywords=python3.9
https://packages.ubuntu.com/search?keywords=python3.10
https://packages.ubuntu.com/search?keywords=python3.11

hanhanW added a commit to hanhanW/iree that referenced this pull request Aug 29, 2023
@hanhanW
Update documentations and setups to Python 3.9
b7ded8e 
The python minimum support was bumped to 3.9 in iree-org#14810
@hanhanW hanhanW mentioned this pull request Aug 29, 2023
Merged
hanhanW added a commit that referenced this pull request Aug 30, 2023
@hanhanW
Update documentations and setups to Python 3.9 (#14860)
9ed3dab 
The python minimum support was bumped to 3.9 in #14810 This is a follow-up to update other documents and setups to Python 3.9.

Fixes #14863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcindyl hcindyl hcindyl left review comments

@stellaraccident stellaraccident stellaraccident approved these changes

@pzread pzread pzread approved these changes

@ScottTodd ScottTodd ScottTodd approved these changes

@rsuderman rsuderman Awaiting requested review from rsuderman rsuderman is a code owner

Assignees
No one assigned
Labels
benchmarks:android-cpu Run default Android CPU benchmarks benchmarks:android-gpu Run default Android GPU benchmarks benchmarks:comp-stats Run default compilation statistics benchmarks benchmarks:cuda Run default CUDA benchmarks benchmarks:vulkan-nvidia Run default Vulkan benchmarks on NVIDIA GPU benchmarks:x86_64 Run default x86_64 benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOSA importer failed after 08-17-2023 integrate
5 participants
@hanhanW @ScottTodd @stellaraccident @hcindyl @pzread