Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain PYTHONPATH setup in build instructions. #14834

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Explain PYTHONPATH setup in build instructions. #14834

merged 3 commits into from
Nov 9, 2023

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Aug 25, 2023 •
edited
Loading

As requested here on Discord.

Also

  • Suggest using help(iree.[compiler|runtime]) to show that import was successful, rather than just import, which has no output
  • Write out .env.ps1 for PowerShell usage on Windows

@ScottTodd ScottTodd added documentation ✏️ Improvements or additions to documentation bindings/python Python wrapping IREE's C API labels Aug 25, 2023
@ScottTodd ScottTodd enabled auto-merge (squash) September 1, 2023 22:17
stellaraccident
stellaraccident approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day I would still like our packages to work with pip install -e vs PYTHONPATH munging, like the rest of the modern world. But better to document what we have vs not.

@ScottTodd ScottTodd merged commit 2fe00a5 into iree-org:main Nov 9, 2023
54 checks passed
@ScottTodd ScottTodd deleted the docs-python-env branch November 9, 2023 18:46
ramiro050 pushed a commit to ramiro050/iree that referenced this pull request Dec 19, 2023
@ScottTodd @ramiro050
Explain PYTHONPATH setup in build instructions. (iree-org#14834)
3dfa96e 
As requested [here on
Discord](https://discord.com/channels/689900678990135345/706175572920762449/1144535632039915564).

Also
* Suggest using `help(iree.[compiler|runtime])` to show that import was
successful, rather than just `import`, which has no output
* Write out `.env.ps1` for PowerShell usage on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
bindings/python Python wrapping IREE's C API documentation ✏️ Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottTodd @stellaraccident