Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] Add command-line option to drop legacy sync mode #15582

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

antiagainst
Copy link
Contributor

@antiagainst antiagainst commented Nov 14, 2023

Legacy sync mode forces waiting on semaphore immediately so
it effectively runs all async allocation/execution in sync mode.
Now we have proper semaphore emulation in cuda2, we don't
need this anymore. Disable it for end-to-end op tests for
experimental cuda2 driver.

Progress towards #13245

Enabled this for end-to-end op tests for experimental cuda2 driver.
@antiagainst antiagainst added the hal/cuda Runtime CUDA HAL backend label Nov 14, 2023
@antiagainst antiagainst merged commit 643b467 into iree-org:main Nov 14, 2023
58 checks passed
@antiagainst antiagainst deleted the cuda2-drop-legacy-sync branch November 14, 2023 17:05
ramiro050 pushed a commit to ramiro050/iree that referenced this pull request Dec 19, 2023
Legacy sync mode forces waiting on semaphore immediately so
it effectively runs all async allocation/execution in sync mode.
Now we have proper semaphore emulation in cuda2, we don't
need this anymore. Disable it for end-to-end op tests for
experimental cuda2 driver.

Progress towards iree-org#13245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hal/cuda Runtime CUDA HAL backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants