[cuda] Drop cuda1 HAL implementation code #16188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now cuda2 is the default; we can drop cuda1 to reduce maintenance.
benvanik
approved these changes
Jan 24, 2024
|
|
|
I'll stage it here for some time and land likely end of the week. :) |
ScottTodd
approved these changes
Jan 25, 2024
Comment on lines
-305
to
-307
| iree_check_single_backend_test_suite( | ||
| NAME | ||
| check_cuda_graph |
There was a problem hiding this comment.
FYI, my recent #16086 is working as intended here :D
When 'cuda' was enabled and 'cuda2' was disabled: https://github.com/openxla/iree/actions/runs/7632069510/job/20791981080#step:7:1203
The following tests did not run:
593 - iree/tests/e2e/stablehlo_ops/check_cuda2_graph_abs.mlir (Disabled)
594 - iree/tests/e2e/stablehlo_ops/check_cuda2_graph_add.mlir (Disabled)
After the flip, when 'cuda2' was enabled' and 'cuda' was disabled:
https://github.com/openxla/iree/actions/runs/7632476397/job/20793221872#step:7:1221
The following tests did not run:
471 - iree/tests/e2e/stablehlo_ops/check_cuda_graph_abs.mlir (Disabled)
472 - iree/tests/e2e/stablehlo_ops/check_cuda_graph_add.mlir (Disabled)
Prior to that change, the disabled targets wouldn't appear in ctest output at all. Now it is pretty clear what is enabled or disabled. (I could have checked that on the flip PR itself, but I forgot :P)
There was a problem hiding this comment.
Ah, nice to know!
Groverkss
pushed a commit
that referenced
this pull request
Feb 2, 2024
Now cuda2 is the default; we can drop cuda1 to reduce maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now cuda2 is the default; we can drop cuda1 to reduce maintenance.
Related to #13245