Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] Drop cuda1 HAL implementation code #16188

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

antiagainst
Copy link
Contributor

@antiagainst antiagainst commented Jan 24, 2024

Now cuda2 is the default; we can drop cuda1 to reduce maintenance.

Related to #13245

Now cuda2 is the default; we can drop cuda1 to reduce maintenance.
@antiagainst antiagainst added hal/cuda Runtime CUDA HAL backend cleanup 🧹 labels Jan 24, 2024
@benvanik
Copy link
Collaborator

champagne-popping-cork-blow-4zoaopphhcna4bp6 1

@antiagainst antiagainst marked this pull request as ready for review January 24, 2024 03:32
@antiagainst
Copy link
Contributor Author

I'll stage it here for some time and land likely end of the week. :)

Comment on lines -305 to -307
iree_check_single_backend_test_suite(
NAME
check_cuda_graph
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, my recent #16086 is working as intended here :D

When 'cuda' was enabled and 'cuda2' was disabled: https://github.com/openxla/iree/actions/runs/7632069510/job/20791981080#step:7:1203

The following tests did not run:
	593 - iree/tests/e2e/stablehlo_ops/check_cuda2_graph_abs.mlir (Disabled)
	594 - iree/tests/e2e/stablehlo_ops/check_cuda2_graph_add.mlir (Disabled)

After the flip, when 'cuda2' was enabled' and 'cuda' was disabled:
https://github.com/openxla/iree/actions/runs/7632476397/job/20793221872#step:7:1221

The following tests did not run:
	471 - iree/tests/e2e/stablehlo_ops/check_cuda_graph_abs.mlir (Disabled)
	472 - iree/tests/e2e/stablehlo_ops/check_cuda_graph_add.mlir (Disabled)

Prior to that change, the disabled targets wouldn't appear in ctest output at all. Now it is pretty clear what is enabled or disabled. (I could have checked that on the flip PR itself, but I forgot :P)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice to know!

@antiagainst antiagainst merged commit cfe865f into iree-org:main Jan 27, 2024
61 checks passed
@antiagainst antiagainst deleted the cuda-drop-cuda1 branch January 27, 2024 01:18
Groverkss pushed a commit that referenced this pull request Feb 2, 2024
Now cuda2 is the default; we can drop cuda1 to reduce maintenance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 hal/cuda Runtime CUDA HAL backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants