Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update docs about the CUDA HAL driver #16234

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

antiagainst
Copy link
Contributor

@antiagainst antiagainst commented Jan 28, 2024

Related to #13245

@antiagainst antiagainst added documentation ✏️ Improvements or additions to documentation hal/cuda Runtime CUDA HAL backend labels Jan 28, 2024
@antiagainst antiagainst changed the title [doc] Update documentation regarding the CUDA HAL driver [doc] Update docs about the CUDA HAL driver Jan 28, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done deleting the link. Moved the example to the blog post to avoid broken reference.

I'd like to expose these to the website as the next step; though still would prefer to keep them in the hal/drivers directory so it's also easier for folks just look around source code tree.. Is it possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure... and I'd rather not blur the line too much there (lint and other CI scripts are simpler if they can segment by directory path). You could at least put a short README that just links to the other source file and/or website page

@antiagainst antiagainst merged commit 1c83020 into iree-org:main Jan 29, 2024
49 checks passed
@antiagainst antiagainst deleted the cuda-update-doc branch January 29, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ✏️ Improvements or additions to documentation hal/cuda Runtime CUDA HAL backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants