Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EmitC] Fix Windows builds #18546

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

simon-camp
Copy link
Contributor

@simon-camp simon-camp commented Sep 18, 2024

_alloca(0) returns NULL on the Windows runner, so we make sure to pad stack allocations to at least one byte.

Fixes #18428

Signed-off-by: Simon Camphausen <simon.camphausen@iml.fraunhofer.de>
Signed-off-by: Simon Camphausen <simon.camphausen@iml.fraunhofer.de>
@simon-camp
Copy link
Contributor Author

simon-camp commented Sep 18, 2024

Let's wait on the Windwos CI run here: https://github.com/simon-camp/iree/actions/runs/10923624650/job/30320695805

@simon-camp simon-camp marked this pull request as draft September 18, 2024 14:06
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success!

@simon-camp simon-camp marked this pull request as ready for review September 18, 2024 20:58
Signed-off-by: Simon Camphausen <simon.camphausen@iml.fraunhofer.de>
@ScottTodd ScottTodd merged commit ae6e5d3 into iree-org:main Sep 23, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build bot fails on EmitC related tests
2 participants