Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove call to t() in external param example. #18706

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

vinayakdsci
Copy link
Contributor

@vinayakdsci vinayakdsci commented Oct 7, 2024

Fixes #18564.

The example in https://iree.dev/guides/ml-frameworks/pytorch/#using-external-parameters has an erroneous call to t() that actually transposes the underlying tensor instead of accessing it unmodified.

This patch fixes this error, and the example now outputs a numerical match with the torch output.

Copy link
Contributor

@kumardeepakamd kumardeepakamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vinayakdsci vinayakdsci merged commit 8f3f1e2 into iree-org:main Oct 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update torch export docs with modern canonical usage
4 participants