-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codegen] Drop TransformStrategies #18820
Conversation
The strategies in TransformStrategies have been off by default for some time and are unmaintained. Drop all related code and tests. Some previous pipeline tests are combined into existing pipeline tests and simplified so that they are no longer change detectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Love deleting code :D
compiler/src/iree/compiler/Codegen/TransformStrategies/BUILD.bazel
Outdated
Show resolved
Hide resolved
llvm::cl::opt<bool> clEnableTransformDialectJit( | ||
"iree-llvmcpu-enable-transform-dialect-jit", | ||
llvm::cl::desc("enable the usage of the transform dialect JIT"), | ||
llvm::cl::init(false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add a bullet point to the pending release notes at #18432 mentioning this deprecation/removal. If some of this was user-facing (e.g. if flags like this were set in other repositories that we know of), could also include migration instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and edited the release notes message there, let me know if that looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Edited a bit:
- The
--iree-codegen-*-transform-dialect-jit
flags have been off by default for a while and were removed across all backends: 012f8a6
compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUSelectLoweringStrategy.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/LLVMGPUSelectLoweringStrategy.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo!
The strategies in TransformStrategies have been off by default for some time and are unmaintained. Drop all related code and tests. Some previous pipeline tests are combined into existing pipeline tests and simplified so that they are no longer change detectors.