[Codegen] Drop TransformStrategies #18820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strategies in TransformStrategies have been off by default for some time and are unmaintained. Drop all related code and tests. Some previous pipeline tests are combined into existing pipeline tests and simplified so that they are no longer change detectors.
qedawkins
requested review from
MaheshRavishankar,
antiagainst,
kuhar,
Groverkss and
hanhanW
as code owners
ScottTodd
approved these changes
Oct 17, 2024
compiler/src/iree/compiler/Codegen/TransformStrategies/BUILD.bazel
Outdated
Show resolved
Hide resolved
Comment on lines
-104
to
-107
| llvm::cl::opt<bool> clEnableTransformDialectJit( | ||
| "iree-llvmcpu-enable-transform-dialect-jit", | ||
| llvm::cl::desc("enable the usage of the transform dialect JIT"), | ||
| llvm::cl::init(false)); |
There was a problem hiding this comment.
Could add a bullet point to the pending release notes at #18432 mentioning this deprecation/removal. If some of this was user-facing (e.g. if flags like this were set in other repositories that we know of), could also include migration instructions.
There was a problem hiding this comment.
I went ahead and edited the release notes message there, let me know if that looks good.
There was a problem hiding this comment.
Thanks. Edited a bit:
- The
--iree-codegen-*-transform-dialect-jitflags have been off by default for a while and were removed across all backends: 012f8a6
ScottTodd
added
codegen
Groverkss
reviewed
Oct 17, 2024
compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUSelectLoweringStrategy.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/LLVMGPU/LLVMGPUSelectLoweringStrategy.cpp
Show resolved
Hide resolved
hanhanW
approved these changes
Oct 17, 2024
compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUSelectLoweringStrategy.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategies in TransformStrategies have been off by default for some time and are unmaintained. Drop all related code and tests. Some previous pipeline tests are combined into existing pipeline tests and simplified so that they are no longer change detectors.