Adding 'amdgpu' target device and flatbuffer for HAL executables. #18933
+321
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
force-pushed
the
users/benvanik/amdgpu-fb
branch
from
c93658f
to
c22dc92
Compare
benvanik
force-pushed
the
users/benvanik/amdgpu-fb
branch
from
c22dc92
to
c9edf87
Compare
|
lol didn't have the ROCM target enabled on the machine I was testing compilation on - kept wondering why the bot was finding issues I wasn't 🤦 |
benvanik
force-pushed
the
users/benvanik/amdgpu-fb
branch
from
c9edf87
to
5790006
Compare
benvanik
force-pushed
the
users/benvanik/amdgpu-fb
branch
from
5790006
to
39ca877
Compare
ScottTodd
reviewed
Oct 29, 2024
ScottTodd
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema may change as the branch gets closer to merging but the refactoring in the compiler for serializing multiple ABIs will remain the same.