Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "[DispatchCreation] Run preprocessing before..." #18939

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IanWood1
Copy link
Contributor

@IanWood1 IanWood1 commented Oct 29, 2024

Land #18934 after fixing mi250 regressions.

@IanWood1
Copy link
Contributor Author

IanWood1 commented Oct 29, 2024

Update: the only difference in the IR after dispatch region creation is the indexing maps. This seems to be an issue where codegen handles transposed input better than transposed output (although they are trivially interchangeable).

Also, in these examples, the linalg.generics should be fused with their consumers (conv_2d). This requires bubbling expand_shape through collapse_shape ops. This would probably also resolve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant