Add integer range inference to hal.buffer_view.dim and rank ops. #18943
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches that default range behavior of runtime dimensions we get from frontends. Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
|
Beautiful. We realistically could go lower (virtual address spaces are usually 48 bits), and when we go to workgroup counts we can go even lower (most implementations limit to 32bit xy and 16bit z). |
benvanik
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches that default range behavior of runtime dimensions we get from frontends.