release charts/kafka-ha 16.0.0

itboon · Apr 4, 2024 · 3378299 · 3378299
1 parent 6be1260
commit 3378299
Show file tree

Hide file tree

Showing 13 changed files with 89 additions and 83 deletions.
diff --git a/charts/kafka-ha/Chart.yaml b/charts/kafka-ha/Chart.yaml
@@ -3,7 +3,7 @@ name: kafka-ha
 description: Helm chart for Apache Kafka.
 type: application
 
-version: 15.0.0
+version: 16.0.0
 appVersion: v3.6.1
 
 maintainers:

diff --git a/charts/kafka-ha/templates/_container.tpl b/charts/kafka-ha/templates/_container.tpl
diff --git a/charts/kafka-ha/templates/_helpers.tpl b/charts/kafka-ha/templates/_helpers.tpl
@@ -128,3 +128,10 @@ kafka combinedMode
 {{- print "false" -}}
 {{- end -}}
 {{- end -}}
+
+{{/*
+kafka clusterDomain
+*/}}
+{{- define "kafka.clusterDomain" -}}
+{{- default "cluster.local" .Values.clusterDomain -}}
+{{- end -}}
diff --git a/charts/kafka-ha/templates/_kafka-env.tpl b/charts/kafka-ha/templates/_kafka-env.tpl
@@ -1,8 +1,17 @@
+{{/*
+KAFKA broker domainSuffix
+*/}}
+{{- define "kafka.broker.domainSuffix" -}}
+{{- $serviceName := include "kafka.broker.headless.serviceName" . -}}
+{{- $namespace := .Release.Namespace -}}
+{{- $clusterDomain := ( include "kafka.clusterDomain" .) -}}
+{{- printf "%s.%s.svc.%s" $serviceName $namespace $clusterDomain -}}
+{{- end -}}
+
 {{/*
 KAFKA_CFG_CONTROLLER_QUORUM_VOTERS
 */}}
 {{- define "kafka.controller.quorum.voters" -}}
-{{- $controllerPort := int .Values.containerPort.controller }}
 {{- $controllerReplicaCount := int .Values.controller.replicaCount }}
 {{- $controllerFullName := include "kafka.controller.fullname" . }}
 {{- $serviceName := include "kafka.controller.headless.serviceName" . }}
@@ -12,10 +21,15 @@ KAFKA_CFG_CONTROLLER_QUORUM_VOTERS
   {{- $serviceName = include "kafka.broker.headless.serviceName" . }}
 {{- end }}
 {{- $namespace := .Release.Namespace -}}
-{{- range $i := until $controllerReplicaCount }}
-  {{- if gt $i 0 }}{{ printf "," }}{{ end }}{{ printf "%d@%s-%d.%s.%s.svc:%d" $i $controllerFullName $i $serviceName $namespace $controllerPort }}
-{{- end }}
-{{- end }}
+{{- $clusterDomain := ( include "kafka.clusterDomain" .) -}}
+{{- $port := int .Values.containerPort.controller }}
+{{- $suffix := printf "%s.%s.svc.%s:%d" $serviceName $namespace $clusterDomain $port -}}
+  {{- $servers := list -}}
+  {{- range $i := until $controllerReplicaCount -}}
+    {{- $servers = printf "%d@%s-%d.%s" $i $controllerFullName $i $suffix | append $servers -}}
+  {{- end -}}
+{{ join "," $servers }}
+{{- end -}}
 
 {{/*
 KAFKA Broker Componet label
@@ -62,7 +76,6 @@ controller env
 broker env
 */}}
 {{- define "kafka.broker.containerEnv" -}}
-{{- $replicaCount := .Values.broker.replicaCount | int -}}
 - name: POD_HOST_IP
   valueFrom:
     fieldRef:
@@ -90,7 +103,8 @@ broker env
   value: "BROKER://0.0.0.0:{{ .Values.containerPort.broker }},EXTERNAL://0.0.0.0:{{ .Values.containerPort.brokerExternal }}"
   {{- end }}
 - name: KAFKA_CFG_ADVERTISED_LISTENERS
-  value: "BROKER://$(POD_IP):{{ .Values.containerPort.broker }}"
+  {{- $domainSuffix := (include "kafka.broker.domainSuffix" .) }}
+  value: "BROKER://$(POD_NAME).{{ $domainSuffix }}:{{ .Values.containerPort.broker }}"
 {{- if .Values.broker.external.enabled }}
 - name: KAFKA_EXTERNAL_SERVICE_TYPE
   value: {{ .Values.broker.external.service.type | quote }}
@@ -105,13 +119,14 @@ broker env
   value: CONTROLLER
 - name: KAFKA_CFG_CONTROLLER_QUORUM_VOTERS
   value: {{ include "kafka.controller.quorum.voters" . }}
+{{- $replicaCount := .Values.broker.replicaCount | int }}
 {{- if and $replicaCount (ge $replicaCount 3) }}
 - name: KAFKA_CFG_DEFAULT_REPLICATION_FACTOR
   value: "3"
 - name: KAFKA_CFG_MIN_INSYNC_REPLICAS
   value: "2"
 - name: KAFKA_CFG_NUM_PARTITIONS
-  value: "9"
+  value: "6"
 - name: KAFKA_CFG_OFFSETS_TOPIC_REPLICATION_FACTOR
   value: "3"
 - name: KAFKA_CFG_TRANSACTION_STATE_LOG_REPLICATION_FACTOR
@@ -179,15 +194,14 @@ kafka fullNodePorts
 KAFKA BOOTSTRAPSERVERS
 */}}
 {{- define "kafka.bootstrapServers" -}}
-{{- $servers := list -}}
-{{- $brokerPort := .Values.containerPort.broker | int -}}
-{{- $brokerReplicaCount := int .Values.broker.replicaCount -}}
 {{- $brokerFullName := include "kafka.broker.fullname" . -}}
-{{- $serviceName := include "kafka.broker.headless.serviceName" . -}}
-{{- $namespace := .Release.Namespace -}}
-{{- range $i := until $brokerReplicaCount -}}
-  {{- $servers = printf "%s-%d.%s.%s.svc:%d" $brokerFullName $i $serviceName $namespace $brokerPort | append $servers -}}
-{{- end -}}
+{{- $domainSuffix := (include "kafka.broker.domainSuffix" .) -}}
+{{- $brokerPort := .Values.containerPort.broker | int -}}
+  {{- $servers := list -}}
+  {{- $brokerReplicaCount := int .Values.broker.replicaCount -}}
+  {{- range $i := until $brokerReplicaCount -}}
+    {{- $servers = printf "%s-%d.%s:%d" $brokerFullName $i $domainSuffix $brokerPort | append $servers -}}
+  {{- end -}}
 {{ join "," $servers }}
 {{- end -}}
 

diff --git a/charts/kafka-ha/templates/broker/statefulset.yaml b/charts/kafka-ha/templates/broker/statefulset.yaml
@@ -92,17 +92,10 @@ spec:
       {{- end }}
         env:
           {{- include "kafka.broker.containerEnv" . | nindent 8 }}
-        #- name: KAFKA_CFG_ADVERTISED_LISTENERS
-        #  value: "foo"
         ports:
           {{- include "kafka.broker.containerPorts" . | nindent 8 }}
-        livenessProbe:
-          exec:
-            command:
-            - sh
-            - -c
-            - bin/kafka-broker-api-versions.sh --bootstrap-server=127.0.0.1:{{ $brokerPort }}
         {{- with $thisValues.livenessProbe }}
+        livenessProbe:
           {{- toYaml . | nindent 10 }}
         {{- end }}
         readinessProbe:
@@ -132,8 +125,6 @@ spec:
           preStop:
             exec:
               command: ["sh", "-c", "sleep 10; bin/kafka-server-stop.sh"]
-      initContainers:
-        {{- include "kafka.initContainer.checkClusterId" . | nindent 8 }}
       terminationGracePeriodSeconds: {{ $thisValues.terminationGracePeriodSeconds }}
       volumes:
       - name: entrypoint-sh

diff --git a/charts/kafka-ha/templates/broker/svc-headless.yaml b/charts/kafka-ha/templates/broker/svc-headless.yaml
@@ -11,15 +11,13 @@ metadata:
 spec:
   type: ClusterIP
   clusterIP: None
-  {{- if .Values.broker.combinedMode.enabled }}
   publishNotReadyAddresses: true
-  {{- end }}
   ports:
     - port: {{ .Values.broker.service.port }}
       targetPort: broker
       protocol: TCP
       name: broker
-    {{- if .Values.broker.combinedMode.enabled }}
+    {{- if (eq (include "kafka.combinedMode" .) "true") }}
     - port: {{ .Values.controller.service.port }}
       targetPort: controller
       protocol: TCP

diff --git a/charts/kafka-ha/templates/broker/svc.yaml b/charts/kafka-ha/templates/broker/svc.yaml
@@ -8,6 +8,9 @@ metadata:
   labels:
     {{- include "kafka.labels" . | nindent 4 }}
     component: {{ $componet | quote }}
+    {{- with $svcValues.labels }}
+    {{- toYaml . | nindent 4 }}
+    {{- end }}
   {{- with $svcValues.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/kafka-ha/templates/controller/statefulset.yaml b/charts/kafka-ha/templates/controller/statefulset.yaml
@@ -126,8 +126,6 @@ spec:
           preStop:
             exec:
               command: ["sh", "-c", "sleep 10; bin/kafka-server-stop.sh"]
-      initContainers:
-        {{- include "kafka.initContainer.checkClusterId" . | nindent 8 }}
       terminationGracePeriodSeconds: {{ $thisValues.terminationGracePeriodSeconds }}
       volumes:
       - name: entrypoint-sh

diff --git a/charts/kafka-ha/templates/controller/svc.yaml b/charts/kafka-ha/templates/controller/svc.yaml
@@ -1,4 +1,4 @@
-{{- if not .Values.broker.combinedMode.enabled }}
+{{- if (eq (include "kafka.combinedMode" .) "false") }}
 {{- $thisFullName := include "kafka.controller.headless.serviceName" . }}
 {{- $componet := "controller" }}
 apiVersion: v1

diff --git a/charts/kafka-ha/templates/exporter/deployment.yaml b/charts/kafka-ha/templates/exporter/deployment.yaml
@@ -53,7 +53,7 @@ spec:
           imagePullPolicy: {{ $thisValues.image.pullPolicy }}
           ports:
             - containerPort: 9308
-              name: http-metrics
+              name: {{ $thisValues.containerPortName | default "http-metrics"}}
               protocol: TCP
           {{- with $thisValues.resources }}
           resources:

diff --git a/charts/kafka-ha/templates/exporter/service.yaml b/charts/kafka-ha/templates/exporter/service.yaml
@@ -0,0 +1,26 @@
+{{- if and .Values.exporter.enabled .Values.exporter.service }}
+{{- $svcValues := .Values.exporter.service }}
+{{- $componet := "kafka-exporter" }}
+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ include "kafka.exporter.fullname" . }}
+  labels:
+    {{- include "kafka.labels" . | nindent 4 }}
+    {{- with $svcValues.labels }}
+    {{- toYaml . | nindent 4 }}
+    {{- end }}
+  {{- with $svcValues.annotations }}
+  annotations:
+    {{- toYaml . | nindent 4 }}
+  {{- end }}
+spec:
+  ports:
+    - name: {{ $svcValues.portName | default "http-metrics" }}
+      port: {{ $svcValues.port | default 9308 }}
+      targetPort: {{ .Values.exporter.containerPortName | default "http-metrics" }}
+      protocol: TCP
+  selector:
+    {{- include "kafka.selectorLabels" . | nindent 4 }}
+    component: {{ $componet | quote }}
+{{- end }}
diff --git a/charts/kafka-ha/templates/ui/service.yaml b/charts/kafka-ha/templates/ui/service.yaml
@@ -6,6 +6,9 @@ metadata:
   name: {{ include "kafka.ui.fullname" . }}
   labels:
     {{- include "kafka.labels" . | nindent 4 }}
+    {{- with $svcValues.labels }}
+    {{- toYaml . | nindent 4 }}
+    {{- end }}
   {{- with $svcValues.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}

diff --git a/charts/kafka-ha/values.yaml b/charts/kafka-ha/values.yaml
@@ -4,6 +4,7 @@
 
 nameOverride: "kafka"
 fullnameOverride: ""
+clusterDomain: "cluster.local"
 
 # It is recommended to use a random cluster id for each cluster.
 # cat /proc/sys/kernel/random/uuid | base64 | cut -b 1-22
@@ -62,17 +63,13 @@ broker:
 
   ## broker.readinessProbe
   readinessProbe:
-    initialDelaySeconds: 25
-    periodSeconds: 10
+    initialDelaySeconds: 50
+    periodSeconds: 20
     timeoutSeconds: 5
     failureThreshold: 3
 
   ## broker.livenessProbe
-  livenessProbe:
-    initialDelaySeconds: 300
-    periodSeconds: 30
-    timeoutSeconds: 5
-    failureThreshold: 5
+  livenessProbe: {}
 
   ## broker.nodeSelector
   nodeSelector: {}
@@ -146,13 +143,13 @@ controller:
     failureThreshold: 3
 
   ## controller.livenessProbe
-  livenessProbe:
-    tcpSocket:
-      port: controller
-    initialDelaySeconds: 300
-    periodSeconds: 30
-    timeoutSeconds: 5
-    failureThreshold: 5
+  livenessProbe: {}
+    # tcpSocket:
+    #   port: controller
+    # initialDelaySeconds: 300
+    # periodSeconds: 30
+    # timeoutSeconds: 5
+    # failureThreshold: 5
 
   ## controller.nodeSelector
   nodeSelector: {}
@@ -196,6 +193,10 @@ exporter:
     requests:
       cpu: 50m
       memory: 128Mi
+
+  ## exporter.service
+  service:
+    annotations: {}
 
 ui:
   enabled: false