os2forms_f2 - #1
Conversation
320428e to
759c978
Compare
jekuaitk
left a comment
jekuaitk
left a comment
There was a problem hiding this comment.
A couple comments and/or requests otherwise good!
| // Run only when submission is completed. | ||
| // @todo Run on update? |
There was a problem hiding this comment.
We should add states as seen in OS2Forms/os2forms_get_organized#30 or OS2Forms/os2forms#333!
| final class WebformHandlerF2 extends WebformHandlerBase { | ||
| use StringTranslationTrait; | ||
|
|
||
| public const string ID = 'os2forms_f2_f2'; |
There was a problem hiding this comment.
It's the “f2” handler in the "os2forms_f2" module … I get your point … And this ID does not match the one actually assigned to the handler (cf.
).Can you live with the change in d80a758?
There was a problem hiding this comment.
Previously we haven't been above giving handlers the same id as the module (name) they live in ("os2forms_f2") although it may seem a tad strange, c.f. https://selvbetjening.aarhuskommune.dk/da/admin/os2forms_selvbetjening_overview/handlers . I can live with both ways as long as the ID's match!
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
2 participants
https://leantime.itkdev.dk/_#/tickets/showTicket/8102