Feature set 178. - #93
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Game.IsMainSeries— a hand-set flag separating the numbered entries and their direct sequels from spin-offs.Square Enix has never published a spin-off list, so this is a curation decision rather than anything derivable from a title, which is why it is a flag and not a computed property. The line drawn here puts the direct sequels on the main-series side: FFX-2, FFXIII-2, The After Years and the Compilation of FFVII are set in a numbered entry's world and share its cast, so splitting them off would separate Yuna from Yuna.
Every game currently in the table is a numbered entry or a direct sequel, so the migration backfills the whole catalogue to
true. The column default staysfalse— from here on a new row is far more likely to be a spin-off than another numbered entry, and the dashboard's blank-row builder already defaults bools to false, so the create form lands on the right answer without a special case.Named
IsMainSeriesrather thanIsSpinOffto matchCharacter.IsPlayable, and because it is the framing where both defaults fall the right way.IsMainSeriesonGame, plus the migration and its backfillmain/spin-offbadge column and a checkbox in the games editorGET /games,GET /games/{id})Nothing filters on it yet, deliberately — the puzzle games still draw from the whole catalogue.
🤖 Generated with Claude Code