Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#730 Upgrade bulma to 1.0.2 #733

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EpicGuy4000
Copy link

Which problem is this PR solving?

Resolves #730 - Upgrade bulma to 1.x

Description of the changes

  • Use dartsass transpiler because bulma no longer supports the hugo default libsass.
  • Remove semicolon at end of indented lines because of build errors.

How was this change tested?

  • make build now passes
  • visually there are a few changes since bulma updated their styles as per documentation

Checklist

Use dartsass transpiler because bulma no longer supports
the hugo default libsass.
Remove semicolon at end of indented lines because of build errors.

Signed-off-by: Miroljub Enjakovic <enjakovic@gmail.com>
Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for romantic-neumann-1959d7 failed.

Name Link
🔨 Latest commit c895202
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/66d5daa4b8068600082dfafd

@EpicGuy4000
Copy link
Author

@yurishkuro the build is currently failing because DartSass is not available in the build environment, and it needs to be in order to support Bulma 1.x. This is not something we can circumvent if we want to do the upgrade.

@yurishkuro
Copy link
Member

My preference is to have a normal Node module somewhere with a proper package.json and a build command in it. We should not vendor dependencies, but we can commit the generated stylesheets (generated with said build command). This way we don't need Node as part of the regular build process, only when we want to regenerate the stylesheets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help upgrading bulma
2 participants