Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer covering sidebar menu #761

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

141AQUA-xzy
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • fixed footer covering sidebar menu
  • fixed the text covered by the scroll bar

How was this change tested?

  • tested locally by running it using make develop

Checklist

Signed-off-by: sudesh satpute <sudeshsatpute0@gmail.com>
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 21eda50
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/6713b11be7ccf900088d8286
😎 Deploy Preview https://deploy-preview-761--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@141AQUA-xzy
Copy link
Contributor Author

also fixed the issue in which scrollbar was covering the text
before
image

after
image

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@yurishkuro yurishkuro merged commit 320d60b into jaegertracing:main Oct 19, 2024
10 checks passed
@141AQUA-xzy
Copy link
Contributor Author

I'm grateful for your thank-givings........

Fixed text issue wasn't listed, I found that the text should be more groomed so thought to provide some room.......and it probably looks more clean now and hence it enhances the content outlook.

And fixing that footer behaviour was too arduous,it took too much attention.

I want to report more bugs that I feel, we should be merging with to well-cast the overall outlook.

I think we can also close this issue "Right sidebar is limited in height #744", if it doesn't feel I would love to make it fulfilled.

@yurishkuro
Copy link
Member

yurishkuro commented Oct 21, 2024

@141AQUA-xzy we appreciate any other fixes.

I think we can also close this issue "Right sidebar is limited in height #744"

That one doesn't seem to me to be fixed. https://www.jaegertracing.io/docs/1.61/apis/ still only takes part of the screen, especially at different zoom levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The footer should not be covering sidebar menus
2 participants