Use Jameel Institute pkgdown template #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
requested changes
Oct 21, 2024
DESCRIPTION
Outdated
| comment = c(ORCID = "0000-0001-8076-1106")), | ||
| person("Robert", "Johnson", role = "aut", | ||
| comment = c(ORCID = "0000-0002-7365-0042")), | ||
| person("Richard", "Fitzjohn", role = "aut", |
There was a problem hiding this comment.
Suggested change
| person("Richard", "Fitzjohn", role = "aut", | |
| person("Rich", "FitzJohn", role = "aut", |
There was a problem hiding this comment.
Can you put David in here too please?
richfitz
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package to use the Jameel Institute {pkgdown} template.
Happy to change elements of the design in future - this one's just to get the website looking decent for IDM.
A stylistic choice that departs from Imperial's brand guidelines: the typefaces are taken from Google Fonts as those are easier to work with using {pkgdown}. I'm happy to change to using the Imperial typefaces in future once we have time to work out where the assets should live.
You can see what the site would look like by running the R code: