Put UI header files in their own directory

[softins]

Short description of changes

Update Jamulus.pro to store the generated ui_*.h files in their own ui directory instead of letting them clutter up the project root.

CHANGELOG: Build: Use a separate ui directory for generated ui header files.

Context: Fixes an issue?

No, just helps keep the project root cleaner

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Tested and ready

What is missing until this pull request can be merged?

Review

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[mcfnord]

🤖 AI: In a tree that has already built in place, the ui_*.h left in the project root take precedence over the new ones: INCPATH lists -I. before -Iui, and qmake's dependency scan binds to the root copy — after qmake on this branch, all 76 generated-header dependency entries in Makefile.Release name the root files, none name ui/. A .ui edit then recompiles nothing, and the linked binary still carries the pre-edit strings while the regenerated ui/ui_aboutdlgbase.h carries the new one (Linux, Qt 5.15.13, g++). The same rebinding and the same -I./-Iui order appear on macOS with Qt 5.15.2 and clang. Pinned at e13e013.

Nothing clears the leftovers now: compiler_uic_clean lists only ui/ui_*.h, so make clean and make distclean skip them, and .gitignore keeps them out of git status. One rm ui_*.h fixes a tree permanently — worth a line in the PR description or the CHANGELOG entry, since in-place builds are exactly what this declutters.

Reproduce: build main in place, check out this branch, run qmake, then grep -cE '^[[:space:]]+ui_[a-z]+\.h' Makefile.Release gives 76 and the same pattern with ui/ui_ gives 0; on a fresh clone the two counts are 0 and 76.

Also ui/ in .gitignore is unanchored, so it ignores any nested ui directory, src/ui/ included; /ui/ would scope it to the build output.

[softins]

OK thanks. I'll look at that soon and see if I can make it more robust to switching between branches with and without this change.

[pljones]

If this is going to be a variable, best to use it in DISTCLEAN_DIRS below to prevent drift.

[mcfnord]

🤖 AI: Agreed, and it costs nothing: replacing the literal in both DISTCLEAN_DIRS lines with $$UI_DIR leaves the rm -rf command byte-identical — rm -rf debug release ui .qm — for an in-place build and a shadow build alike, at e13e013 with Qt 5.15.13.

The two forms can only diverge when UI_DIR is passed on the qmake command line, and that case is already broken by the += in UI_DIR += ui: the override becomes the two-element list build-ui ui, uic then generates nothing, and Makefile.Release goes from 76 generated-header dependency entries to 0. Spelling it UI_DIR = ui keeps such an override working and makes $$UI_DIR exact rather than coincidental.