Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

Add remove user feature #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add remove user feature #1

wants to merge 1 commit into from

Conversation

Maliek
Copy link

@Maliek Maliek commented Apr 16, 2018

Hi,

Can't resist coding 😉 Any feedback welcome!

@jan-tee
Copy link
Owner

jan-tee commented May 9, 2018

Thank you for working on this, I am looking forward to adding more community contributions! And you are first 🥇

I think this operation should work on the basis of the user object, for consistency with everything else, not primarily the user ID. IOW between

Get-CyUserList | where email -eq 'johndoe@somewhere' | Remove-CyUser

there should not be a requirement for a step like

Get-CyUserList | where email -eq 'john@doe.com' | foreach-object { Remove-CyUser -ByUserId $_.user_id }

The spirit of the module should be to make the API very Powershell-like and human discoverable in terms of verbs, operating on pipelines of objects, etc. So I think this needs to be revised to support operating on object pipeline for users and delete by email. Delete by ID is not a good scenario because the ID is not typically available, unless you jump through hoops like in the example above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants