Merge pull request #35 from hhugo/fix-windows

Fix for windows
janestreet · Nov 12, 2021 · 986043a · 986043a
2 parents c2003b1 + 1693b3a
commit 986043a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/collector/expect_test_collector.ml b/collector/expect_test_collector.ml
@@ -101,7 +101,7 @@ module Make (C : Expect_test_config_types.S) = struct
 
     let create () =
       let filename = Filename.temp_file "expect-test" "output" in
-      let chan = open_out filename in
+      let chan = open_out_bin filename in
       before_test ~output:chan ~stdout ~stderr;
       { chan; filename = File.Name.of_string filename; saved = [] }
     ;;
@@ -120,7 +120,7 @@ module Make (C : Expect_test_config_types.S) = struct
     let relative_filename t = File.Name.relative_to ~dir:(File.initial_dir ()) t.filename
 
     let with_ic fname ~f =
-      let ic = open_in fname in
+      let ic = open_in_bin fname in
       protect ~finally:(fun () -> close_in ic) ~f:(fun () -> f ic)
     ;;