Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job_list self.respond_to? responds to empty @set_variables #830

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

job_list self.respond_to? responds to empty @set_variables #830

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3128e9
job_list self.respond_to? changed to respond to empty @set_variables
brunolarouche Dec 2, 2022
4bd47f6
job_list .respond_to? updated to an instance method
brunolarouche Apr 27, 2023
004e4a5
Merge branch 'javan:main' into main
brunolarouche Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/whenever/job_list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def method_missing(name, *args, &block)
end

def self.respond_to?(name, include_private = false)
@set_variables.has_key?(name) || super
if @set_variables
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always be nil so this is effectively just super

@set_variables.has_key?(name)
end || super
end

def env(variable, value)
Expand Down