Fix sourcemap sourcesContent not aligned to sources #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this pull request fixes the main issue I've been having with this package. I can live with working from the fork, but it'd be nicer if this was also fixed in the main version on the npm registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sourcesarray of merged source maps is not always in the same order as the originalsourcesarray. By using the original source map'ssourcesContenttogether with the merged source map'ssources, the 2 array might not be aligned, which produces a malformed source map.I believe
sourcesContentgets copied from input to the merged source map because themulti-stage-sourcemaplibrary at one point did not producesourcesContent. Butmulti-stage-sourcemaphas added support forsourcesContentsince version0.3.0(this project requires^0.3.1).