Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakMap and WeakSet #196

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Conversation

behrends
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Dec 15, 2023
Copy link
Contributor

@J-Cake J-Cake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


It cleans up itself automatically. The tradeoff is that we can't iterate over it, can't get "all read messages" from it directly. But we can do it by iterating over all messages and filtering those that are in the set.
Es bereinigt sich automatisch. Der Kompromiss ist, dass wir nicht darüber iterieren können, wir können "alle gelesenen Nachrichten" daraus nicht direkt erhalten. Aber wir können dies erreichen, indem wir über alle Nachrichten iterieren und diejenigen filtern, die in der Menge sind.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Übersetzung passt zum Kontext nicht. Hier ist warscheinlich maschinell übersetzt worden?

*... indem wir über alle Nachrichten iterieren und diejenigen aussortieren, die nicht im Set sind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

];
```

The question now is: which data structure you'd suggest to store the information: "when the message was read?".
Die Frage lautet nun: Welche Datenstruktur würdest Du vorschlagen, um die Information zu speichern: „Wann wurde die Nachricht gelesen?“.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die besonderen Anführungszeichten gefallen mir, aber ist nicht konsistent mit der bisherigen Übersetzungsleistung... Müsste leider auch geändert werden :(

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Dec 16, 2023
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@behrends
Copy link
Contributor Author

Done

@J-Cake J-Cake merged commit 4032b78 into javascript-tutorial:master Dec 17, 2023
1 check passed
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Waiting for changes and /done from PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants