Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loops: while and for #84

Merged
merged 31 commits into from
Aug 21, 2021
Merged

Loops: while and for #84

merged 31 commits into from
Aug 21, 2021

Conversation

vahmelk99
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team August 21, 2021 12:46
@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 21, 2021
Open
bugron
bugron requested changes Aug 21, 2021
View reviewed changes
Copy link
Contributor

@bugron bugron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good just a few comments to address. Besides those comments while you're resolving merge conflicts I'll get to reviewing the main article.

1-js/02-first-steps/13-while-for/2-which-value-while/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/5-replace-for-while/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/6-repeat-until-correct/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/7-list-primes/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/7-list-primes/solution.md Show resolved Hide resolved
1-js/02-first-steps/13-while-for/7-list-primes/task.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@vahmelk99
Copy link
Contributor Author

Thanks for the review)

@vahmelk99
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 21, 2021 14:21
bugron
bugron requested changes Aug 21, 2021
View reviewed changes
Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address a few more comments and we're good to go.

1-js/02-first-steps/13-while-for/7-list-primes/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-while-for/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vahmelk99 and others added 18 commits August 21, 2021 19:31
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/7-list-primes/solution.md
5806f13 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
e653e50 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
6f701c6 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
df1e71f 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
9f90054 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
14c423e 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
4ccbb8f 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
6482c5d 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
3f2c9c8 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
132ebde 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
8cef7f2 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
4927262 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
a84d5d3 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
74574c7 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
a76316c 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
b032a1f 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
6ba30b1 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99 @bugron
Update 1-js/02-first-steps/13-while-for/article.md
2de07d1 
Co-authored-by: Arsen Melikyan <bugron@mail.ru>
@vahmelk99
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 21, 2021 15:36
@bugron
Copy link
Contributor

bugron commented Aug 21, 2021

This is awesome! Thanks @vahmelk99 for all your hard work. It is my pleasure to collaborate with you. Way to go! Merged.

@bugron bugron merged commit dd52f90 into javascript-tutorial:master Aug 21, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugron bugron bugron requested changes

Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vahmelk99 @javascript-translate-bot @bugron