Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "new Function" syntax #156

Merged
merged 12 commits into from
May 5, 2024
Merged

Conversation

tfbio
Copy link
Contributor

@tfbio tfbio commented Jul 18, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2020

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor

Hi @tfbio would you please resolve the conflicts, or inform if you may be unavailable to continue with this PR? Thank you.

@odsantos odsantos changed the title Translation for new Function .md The "new Function" syntax Aug 14, 2021
@odsantos
Copy link
Contributor

Hi @tfbio I update this PR article to be conforming to the English version and now there conflicts.
Hope you still are able to resolve them.
Thank you.

@nazarepiedady
Copy link
Member

nazarepiedady commented Mar 10, 2024

@odsantos, @jonnathan-ls, @Peruibeloko, what do you recommend colleagues to be done in this pull request?

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the conflicts (0394ddf), and added some modifications (8c915f8) @nazarepiedady

With this, I register my LGTM

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, so I'll add it to the main branch.

@nazarepiedady nazarepiedady merged commit d936142 into javascript-tutorial:master May 5, 2024
1 check passed
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants