Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging in the browser #399

Merged
merged 8 commits into from
Jun 2, 2024

Conversation

zenobiopereira
Copy link
Contributor

Translated it the best I could, please let me know if there are some kind of convention that I've broken or some kind of phrasing that doesn't seems good.

There's also the hello.js file that I assume it should not have function names translated so I didn't touch it.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ zenobiopereira
✅ odsantos
❌ Zenóbio


Zenóbio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@odsantos
Copy link
Contributor

@zenobiopereira , it seems you took a translated article and are proposing changes.
Do you want your suggestions to be reviewed?
Thanks.

@zenobiopereira
Copy link
Contributor Author

Hey @odsantos , yeah, it seems like the topic already had been translated but at least for me, the text was using multiple terms in which seems like PT-PT, even though, I would be glad if you could review it as proposed changes and if that's not possible then I can jump to translate a different topic.

@odsantos
Copy link
Contributor

Hi @zenobiopereira , yes I'll try to review it as soon as possible. Thanks.

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zenobiopereira ,

Here is a review.
Please don't hesitate to tell me where you disagree.

Thank you,
Osvaldo.

1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/01-debugging-chrome/article.md Outdated Show resolved Hide resolved
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zenobiopereira ,

Here is a review.
Please don't hesitate to tell me where you disagree.

Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@zenobiopereira
Copy link
Contributor Author

zenobiopereira commented Mar 26, 2023

Hey @odsantos thank you for the review, I did applied most of your corrections since pretty much all of them added context and small needed corrections.

I've also left small comments in two requested changes just because I think the text as it is, already delivers the same meaning, please let me know what do you think in relation to those.

Thank you in advance.

@zenobiopereira
Copy link
Contributor Author

/done

@odsantos
Copy link
Contributor

Hi @zenobiopereira left a comment on the review point on discussion. Thanks.

@zenobiopereira
Copy link
Contributor Author

@odsantos
Applied all the changes, let me know if there's something else that might need to be changed.

Thank you in advance.

/done

@odsantos
Copy link
Contributor

Hi @zenobiopereira , will take a look as soon as possible. Thanks.

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embora, ainda considero que o artigo está em um linguajar muito formal, entendo que a necessidade deveria vir de outro momento para refletirmos em relação as colocações de escrita que este repositório em PT pode vir a adotar.

Sendo assim, considero a solicitação: LGTM ( Looks good to me )

@jonnathan-ls jonnathan-ls self-requested a review June 4, 2023 22:29
Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Looks Great To Me)

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady
Copy link
Member

@jonnathan-ls, the language should be formal because programming is science.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks good to me to be approved.

@nazarepiedady nazarepiedady merged commit 6cd1cce into javascript-tutorial:master Jun 2, 2024
1 check was pending
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants