Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic imports #419

Merged

Conversation

danilolmc
Copy link
Contributor

No description provided.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
Copy link
Contributor Author

/done

@nazarepiedady
Copy link
Member

@Peruibeloko, @jonnathan-ls, could you review this pull request?

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added a commit with some adjustments such as pending translations 780f934

@jonnathan-ls
Copy link
Contributor

... could you review this pull request?

I added my review with contribution @nazarepiedady

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, so I will pass it forward.

@nazarepiedady nazarepiedady merged commit 60013b3 into javascript-tutorial:master Apr 8, 2024
1 check passed
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants