Quantifiers +, *, ? and {n} #429
Conversation
There was a problem hiding this comment.
@Peruibeloko, you did a great work here, so there is not so much things to be reviewed.
I will let the rest on your hands and our colleagues.
9-regular-expressions/09-regexp-quantifiers/2-find-html-colors-6hex/task.md
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
|
@jonnathan-ls, could you review it? |
|
@Peruibeloko, I think you could also look at your own pull request and approve it if you agree with what you did. This would help a lot when we don't have enough people online to look at it. |
|
@nazarepiedady that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors |
|
@Peruibeloko, yes, but you are also a reviewer even not being a maintainer. I also think that you have a good point. |
|
/done |
|
@Peruibeloko, excellent, now we can go forward. We need to merge all current opened pull request to do a good review on the issues and to organise the things to start to add new translations. |
I agree with @Peruibeloko in relation to the translator ending up accepting the PR itself, although it is a documentation repository, if we consider the same premise as the code, whoever opened the PR may end up missing errors that they would not end up catching, hence the need to have reviewers for a look beyond the context (this corroborates the project's premise of having 02 reviewers, to avoid possible translation errors and ending up being taken to production when the translation is incorporated into the javascript.info website ' But I also consider @nazarepiedady's observation valid, unfortunately there are few contributors to this project and we need to release the translation. As it is a documentation repository and not a code repository, perhaps we can be a little more flexible, but if we are going to follow a path like this, I think it is worth creating a separate issue first to evaluate the opinion of other maintainers, at the same time time to ensure that we do not violate the premise adopted by the project owner (repository in English). |
|
@Peruibeloko, @jonnathan-ls, unfortunately this project do not have so many active maintainers so if we depend on the maintainers that are not so active we can not go ahead. |
|
@nazarepiedady I think your approval is the only one remaining |
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
No description provided.