Skip to content

fix: appstore update crash and node 20 deprecation warnings - #162

Merged
maxandersen merged 2 commits into
jbangdev:mainfrom
alaurie:fix/appstore-update.yml
Aug 27, 2026
Merged

fix: appstore update crash and node 20 deprecation warnings#162
maxandersen merged 2 commits into
jbangdev:mainfrom
alaurie:fix/appstore-update.yml

Conversation

@alaurie

@alaurie alaurie commented Aug 24, 2026

Copy link
Copy Markdown
Contributor
  • Handle HttpException and IOException gracefully in appstore.java to skip catalogs returning HTTP 400 (e.g. malformed spaces in URLs) instead of retrying indefinitely and crashing the action.
  • Update isSecondaryRateLimit to isRateLimit for broader rate limit detection.
  • Update actions/checkout to v7.0.1 (3d3c42e) and jdx/mise-action to v4.2.5 (3c2e0cf) to resolve Node 20 deprecation warnings and run on Node 24. Pinned to commit hashes to maintain supply chain security policy.

- Handle HttpException and IOException gracefully in appstore.java to skip
  catalogs returning HTTP 400 (e.g. malformed spaces in URLs) instead of
  retrying indefinitely and crashing the action.
- Update isSecondaryRateLimit to isRateLimit for broader rate limit detection.
- Update actions/checkout to v7.0.1 (3d3c42e) and jdx/mise-action to v4.2.5 (3c2e0cf)
  to resolve Node 20 deprecation warnings and run on Node 24. Pinned to commit
  hashes to maintain supply chain security policy.
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d17d539-d55f-47a9-a80a-eee4ca0d353c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alaurie
alaurie force-pushed the fix/appstore-update.yml branch from 0c107b3 to 08fb54f Compare August 24, 2026 06:49
@alaurie

alaurie commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Updated .github/appstore.java dependencies to their latest stable non-RC releases and updated deprecated GitHub API handler references:

  • Dependency Updates:
    • info.picocli:picocli: 4.5.0 → 4.7.7
    • org.kohsuke:github-api: 1.128 → 1.330
    • com.google.code.gson:gson: 2.8.6 → 2.14.0
    • org.commonmark:commonmark* family: 0.17.1 → 0.30.0
  • Deprecation Refactoring:
    • Replaced deprecated AbuseLimitHandler with GitHubAbuseLimitHandler
    • Replaced deprecated RateLimitHandler with GitHubRateLimitHandler

@maxandersen

Copy link
Copy Markdown
Contributor

the action runs to completion locally with no problem - worth a shot if this can help :)

@maxandersen
maxandersen merged commit 4364859 into jbangdev:main Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants