Skip to content

Commit

Permalink
progress, can't change or make new run-program items.
Browse files Browse the repository at this point in the history
  • Loading branch information
@jefflord
jefflord committed Oct 19, 2023
1 parent dd463b7 commit 607c6f0
Show file tree
Hide file tree
Showing 26 changed files with 1,489 additions and 8 deletions.
5 changes: 5 additions & 0 deletions src/modules/keyboardmanager/KeyboardManagerEditor/KeyboardManagerEditor.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#include <EditKeyboardWindow.h>
#include <EditShortcutsWindow.h>
#include <EditRunProgramsWindow.h>
#include <KeyboardManagerState.h>

std::unique_ptr<KeyboardManagerEditor> editor = nullptr;
Expand Down Expand Up @@ -158,6 +159,10 @@ void KeyboardManagerEditor::OpenEditorWindow(KeyboardManagerEditorType type)
break;
case KeyboardManagerEditorType::ShortcutEditor:
CreateEditShortcutsWindow(hInstance, keyboardManagerState, mappingConfiguration);
break;
case KeyboardManagerEditorType::RunProgramEditor:
CreateEditRunProgramsWindow(hInstance, keyboardManagerState, mappingConfiguration);
break;
}
}

Expand Down
1 change: 1 addition & 0 deletions src/modules/keyboardmanager/KeyboardManagerEditor/KeyboardManagerEditor.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ enum class KeyboardManagerEditorType
{
KeyEditor = 0,
ShortcutEditor,
RunProgramEditor,
};

class KeyboardManagerEditor
Expand Down
4 changes: 3 additions & 1 deletion src/modules/keyboardmanager/KeyboardManagerEditor/KeyboardManagerEditor.vcxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@
<Manifest Include="KeyboardManagerEditor.exe.manifest" />
</ItemGroup>
<ItemGroup>
<None Include="Resources.resx" />
<None Include="Resources.resx">
<SubType>Designer</SubType>
</None>
</ItemGroup>
<ItemGroup>
<Image Include="Keyboard.ico" />
Expand Down
3 changes: 3 additions & 0 deletions src/modules/keyboardmanager/KeyboardManagerEditor/Resources.resx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@
<data name="EditShortcuts_WindowName" xml:space="preserve">
<value>Remap shortcuts</value>
</data>
<data name="EditRunPrograms_WindowName" xml:space="preserve">
<value>Run program shortcuts</value>
</data>
<data name="Ok_Button" xml:space="preserve">
<value>OK</value>
</data>
Expand Down
2 changes: 1 addition & 1 deletion src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditKeyboardWindow.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ inline void CreateEditKeyboardWindowImpl(HINSTANCE hInst, KBMEditor::KeyboardMan
SingleKeyRemapTable singleKeyRemapCopy = mappingConfiguration.singleKeyReMap;

LoadingAndSavingRemappingHelper::PreProcessRemapTable(singleKeyRemapCopy);

for (const auto& it : singleKeyRemapCopy)
{
SingleKeyRemapControl::AddNewControlKeyRemapRow(keyRemapTable, keyboardRemapControlObjects, it.first, it.second);
Expand Down
Loading

1 comment on commit 607c6f0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (3)

EDITRUNPROGRAMS
JLO
Programtool

Previously acknowledged words that are now absent administra RSAT systemroot sysvol :arrow_right:
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:jefflord/PowerToys.git repository
on the run-program-shortcuts branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/jefflord/PowerToys/actions/runs/6569408250/attempts/1'
Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (2287) from .github/actions/spell-check/expect.txt and unrecognized words (3)

Dictionary Entries Covers
cspell:win32/src/win32.txt 53509 139
cspell:cpp/src/cpp.txt 30216 132
cspell:python/src/python/python-lib.txt 3873 29
cspell:php/php.txt 2597 20
cspell:node/node.txt 1768 15
cspell:typescript/typescript.txt 1211 13
cspell:java/java.txt 7642 12
cspell:python/src/python/python.txt 453 10
cspell:aws/aws.txt 218 9
cspell:python/src/common/extra.txt 741 8

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:win32/src/win32.txt
          cspell:cpp/src/cpp.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:java/java.txt
          cspell:python/src/python/python.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.