Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deviceCapabilities, fix vp9, and make 6 channel videos downmix if possible #1366

Merged
merged 30 commits into from
Nov 4, 2023

Conversation

sevenrats
Copy link
Member

@sevenrats sevenrats commented Sep 12, 2023

Changes

  • Refactor deviceCapabilities.brs
    • Use separate functions for each type of profile
  • Fix bug in VP9 profile and level support detection (profile/level detection was completely broken but is now fixed)
  • Only allow 8bit videos for the h264 codec
  • Allow the roku device to downmix multichannel audio for users with stereo speakers instead of transcoding down to 2 channels
    • e.g. 6 channel aac files direct play with this PR and my stereo setup instead of "direct streaming" like they do on unstable

@sevenrats sevenrats requested a review from a team as a code owner September 12, 2023 05:11
@sevenrats
Copy link
Member Author

really i feel like we need a user setting if we can't get more specific with the cause.

@cewert
Copy link
Member

cewert commented Sep 30, 2023

You're the only one getting the distorted sounds right now. We need to verify it's not just you before we hardcode it or make a user setting for it.

@cewert cewert changed the title fix unsupported multichannel audio Update device profile Sep 30, 2023
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Oct 3, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Oct 3, 2023
@cewert
Copy link
Member

cewert commented Oct 16, 2023

Setting this to draft. Everything works with one big exception - video files that are transcoded to preserve multichannel audio play as the should but fast forward and rewind no longer work as well as the length of the video showing 0.

EDIT: I moved this code to it's own PR #1466. Everything in this PR is working now and ready for review

@cewert cewert marked this pull request as draft October 16, 2023 00:08
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Oct 16, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Nov 3, 2023
@cewert cewert marked this pull request as ready for review November 3, 2023 01:56
@cewert cewert changed the title Update device profile Refactor deviceCapabilities, fix vp9, and make 6 channel videos downmix if possible Nov 3, 2023
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lakerssuperman and I both threw all we could at it and the stated goals appear to be honored.

Neither of us were able to test VP9 support.

@cewert cewert merged commit 0043c2e into jellyfin:unstable Nov 4, 2023
9 checks passed
@cewert cewert added the bug-fix This fixes a bug. label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants