Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save global refs to prevent deep copies #1945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cewert
Copy link
Member

@cewert cewert commented Sep 30, 2024

This should speed things up a bit for the views being updated, especially on slower devices. ItemGrid and the AudioPlayerView had lots of changes

Changes

  • Save m.global to a local var when m.global is used more than once

@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Sep 30, 2024
@cewert cewert requested a review from a team as a code owner September 30, 2024 14:26
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Oct 6, 2024
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants