Reduce the use of reflection in some rare circumstances (#290)

jenkinsci · Aug 2, 2024 · 009aa10 · 009aa10
1 parent ce94373
commit 009aa10
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectMasterEnvVarsSetter.java b/src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectMasterEnvVarsSetter.java
@@ -43,6 +43,18 @@ private Field getModifiers() throws NoSuchMethodException, InvocationTargetExcep
 
     @Override
     public Void call() throws EnvInjectException {
+        if (EnvVars.masterEnvVars.equals(enVars)) {
+            // Nothing to update
+            return null;
+        } else if (EnvVars.masterEnvVars.keySet().equals(enVars.keySet())) {
+           /*
+            * Per the Javadoc, merely changing the value associated with an existing key is not a structural
+            * modification and thus does not require synchronization.
+            */
+           EnvVars.masterEnvVars.putAll(enVars);
+           return null;
+        }
+
         try {
             Field platformField = EnvVars.class.getDeclaredField("platform");
             platformField.setAccessible(true);