-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for translate() fallback to default locale key/value #29
base: master
Are you sure you want to change the base?
Conversation
… requested locale file don't have the requested key/value.
use the value from the default locale
use the value from the default locale
use the value from the default locale, bugfix
use the value from the default locale, bugfix
use the value from the default locale, bugfix
Well, if you use a german locale, maybe getting an english value when the key is not found is not what users want. |
# Conflicts: # i18n.js
The alternative is just to see the key (that probably also is in english) if the translation is missing for that country... If you use variables in your translations this can get messy. By enabling the fallback to the default country it would be possible to deploy some translations before all the translations are complete, this is useful for large projects. |
Okay this makes some sense Please commit to :
|
@torvalde @gjuchault is this still active? I am looking exactly for this. |
@sceee I'm not an active maintainer this days, and I can't merge a branch with conflicts / not ready. You're free to create another clean pull-request with the same changes if you want. |
Added support for translate() fallback to default locale key/value if requested locale file don't have the requested key/value.