Skip to content

Commit

Permalink
core: plat-bcm: remove virtual address lookup from main_init_gic()
Browse files Browse the repository at this point in the history
- Commit 6080169 ("plat: arm: refactor GIC initialization")
  refactored GIC initialization to have gic_init_base_addr() take in a
  physical address instead of a virtual one, meaning that a virtual
  address lookup is no longer necessary within a platform's gic_init().
- BCM's main_init_gic() would still perform a virtual memory lookup and
  hand over its virtual address instead of the expected physical one.
  This caused the lookup in gic_init_base_addr() to fail and panic.
- This new commit removes the virtual memory lookup from BCM's
  main_gic_init() and instead hands gic_init_base_addr() a physical
  address.

Signed-off-by: Andrew Mustea <andrew.mustea@microsoft.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
  • Loading branch information
andrewmustea authored and jforissier committed Jul 27, 2022
1 parent 3957cdc commit 3c108a7
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions core/arch/arm/plat-bcm/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,6 @@ void itr_core_handler(void)

void main_init_gic(void)
{
vaddr_t gicd_base;

gicd_base = core_mmu_get_va(GICD_BASE, MEM_AREA_IO_SEC, 1);

if (!gicd_base)
panic();

gic_init_base_addr(&gic_data, 0, gicd_base);
gic_init_base_addr(&gic_data, 0, GICD_BASE);
itr_init(&gic_data.chip);

}

0 comments on commit 3c108a7

Please sign in to comment.