Alignment score #80
Open
Alignment score #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all, Just wondering what the status is of this PR? What needs to be done to get it over the line? I'm happy to try and help if necessary. |
Ohhhhh I know the feeling! Thanks so much for this great library/bindings. I'm about to start a project using this library so I'll probably be harassing you a bit over the next couple of weeks 😅 |
|
If you want to take a stab at this (#71), I’m willing to help. Since I found a work around, it’s not top priority for us right now, but it seems important for the lib in general moving forward. —Rob p.s. I too know the feeling (not moving this time, but grants and conference deadlines out the wazoo this past month!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
map_with_namewhich allows resolving #75. Specifically, it passes the query name (which must be\0terminated) to the map function, which allows the internal minimap2 functionmm_mapto resolve ties in the chain score.Though the differences are subtle, this allows exactly replicating the behavior of command-line minimap2, in cases where this tie breaking can result in some alignments being marked supplementary, where they otherwise would not.