-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct gradle jar deployment to heroku #241
correct gradle jar deployment to heroku #241
Conversation
Will check the frontend part for gradle in detail. So don't merge it now. |
@atomfrede Can you please fix conflicts? |
Yes. |
@atomfrede More conflicts now. Can you please fix? |
Will have a look. But I can't test it anymore 😢 |
@atomfrede Do you want to fix this for the 2.0 release (with Micronaut 3) or wait for the 3.0 release (with Micronaut 4)? I'd like to do a 2.0 release today, that's why I ask. |
Won't make for the 2.0 release, sorry. |
@atomfrede Is there anything I can do to help with this issue? |
After fixing the conflicts we can give it a try. If I remember correctly the only problem left was UI related but only when doing a git deploy for which I didn't had any clue why thats happening. |
@atomfrede Can you please fix the conflicts? |
@atomfrede Is this still needed or can be closed? |
Let's close this. I suppose so much has changed its easier to start a new pr |
This fixes the heroku deployment with gradle using the jar deployment. For the git/compile on heroku I have no clue yet. Everything looks fine, but the resources are not build/available on the heroku dyno, although the webpack tasks are executed correctly.
updates #240