Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SentryHandler not handle stack trace #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: SentryHandler not handle stack trace #225

wants to merge 2 commits into from

Conversation

shenjingfs
Copy link

Fix #213 #191

As of Sentry 4.0.0, the type of the SentryEvent.stackTrace has been changed from dynamic to SentryStackTrace, and a new parameter dynamic stackTrace has been added to SentryClient.captureEvent.
The commit #724a4d removes stackTrace in the buildEvent method, but calls SentryClient.captureEvent without adding stackTrace, which causes Sentry to capture StackTrace.current

@definitelyme
Copy link

Can this be merged? @jhomlala
Causing issues in production!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] StackTrace in Sentry is incorrect when using reportCheckedError
2 participants
@shenjingfs @definitelyme