-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre_trans for variable #112
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #112 +/- ##
==========================================
+ Coverage 76.21% 76.37% +0.16%
==========================================
Files 108 109 +1
Lines 15894 15995 +101
Branches 2981 2999 +18
==========================================
+ Hits 12113 12216 +103
+ Misses 3084 3079 -5
- Partials 697 700 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I agree it's worth adding pre-trans function. For var_equal, you can use VarsManager.set_same(). I think it might be better to show it in configuration file as
and |
the list is unhashable, it it unable to use it in the key. |
I have change it to
|
Add transform before read variables. We can set two variable to the same, and add transform for one variable to make the constrains of linear transform. For example,
then
var_name2
will be2 * var_name
.