Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtype aligns in nll #153

Merged
merged 3 commits into from
Oct 16, 2024
Merged

dtype aligns in nll #153

merged 3 commits into from
Oct 16, 2024

Conversation

jonas-eschle
Copy link
Contributor

Hi, small fix: the dtype of the 1.0 is float32, which fails if the function is jitted. This just ensures that the 1 has the same dtype as the weigths.

@jiangyi15
Copy link
Owner

The style check is failed. You can run pre-commit run -a to fix it. See here

@jonas-eschle
Copy link
Contributor Author

Fair, fixed.

Besides, are you aware of/did you consider to use https://pre-commit.ci/? This would solve such problems and automatically run pre-commit on any commit
(I run pre-commit locally, but this was a quick browser edit -> if you register there, it would have automatically taken care of it)

@jiangyi15
Copy link
Owner

Thanks for you suggestion, I will have a try.

@jiangyi15 jiangyi15 merged commit dc0326f into jiangyi15:dev Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants