Skip to content

Commit

Permalink
Improve logging
Browse files Browse the repository at this point in the history
possibly explains why we store password as plain text (#46)
  • Loading branch information
jkotra committed Feb 3, 2024
1 parent 1558afb commit de16dcb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"[c]": {
"editor.defaultFormatter": "xaver.clang-format",
"editor.formatOnSave": true
}
},
"mesonbuild.configureOnOpen": false
}
3 changes: 2 additions & 1 deletion eovpn/settings_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,9 @@ def on_password_stored(source, result):
try:
is_pwd_stored = Secret.password_store_finish(result)
logger.debug(is_pwd_stored)
except Exception:
except Exception as e:
#save as plain text
logger.error("error while saving password: %s", e)
self.set_setting(self.SETTING.AUTH_PASS, entry.get_text())
logger.warning("Password saved as plain text!")

Expand Down

0 comments on commit de16dcb

Please sign in to comment.