Sends copy of documents instead of deleting __collections__. Fixes #328

jloosli · May 8, 2020 · 0b0b792 · 0b0b792
1 parent ab05bd8
commit 0b0b792
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/lib/import.ts b/src/lib/import.ts
@@ -14,7 +14,6 @@ const importData = (data: any,
       throw new Error('Root or document reference doesn\'t contain a __collections__ property.');
     }
     const collections = dataToImport['__collections__'];
-    delete (dataToImport['__collections__']);
     const collectionPromises: Array<Promise<any>> = [];
     for (const collection in collections) {
       if (collections.hasOwnProperty(collection)) {
@@ -53,9 +52,9 @@ const setDocuments = (data: ICollection, startingRef: FirebaseFirestore.Collecti
             collection: data[documentKey]['__collections__'][collection],
           });
         });
-        delete (data[documentKey]['__collections__']);
       }
-      const documentData: any = unserializeSpecialTypes(data[documentKey]);
+      const {__collections__, ...documents} = data[documentKey];
+      const documentData: any = unserializeSpecialTypes(documents);
       batch.set(startingRef.doc(documentKey), documentData, {merge: mergeWithExisting});
     });
     return batch.commit();

diff --git a/tests/import.spec.ts b/tests/import.spec.ts
@@ -69,5 +69,11 @@ describe('Firestore Import', () => {
         expect(true).to.be.true;
       }
     }
-  })
+  });
+
+  it(`should not manipulate imported data object`, async () => {
+    const dump = {name: 'Alice', __collections__: {jobs: {123: {name: 'doctor'}}}};
+    await firestoreImport({['id1']: dump}, mockFirestore.collection('user'));
+    expect(dump.__collections__.jobs['123'].name).to.eql('doctor');
+  });
 });