Small changes to colors and style to new UI - #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the rail circuit background, enlarge the nav identity, separate data surfaces
Three visual corrections, all frontend-only. No behaviour, API or data changes.
1. Restored the circuit background on the side nav
The rail's circuit-trace texture had been reimplemented as a
mask-imageatopacity: 0.055, which renders as very nearly nothing. Restored thev0.5.7block verbatim:.sidenav-circuitwith the tiled inline-SVGbackground-imagein brand teal —#2bc4beat 0.08 in dark,#0a8a85at 0.10 in light, alphas tuned per theme so both read at similar perceived density — layered under the teal sheen gradient at the top of the rail.SideNav.tsxreferences the release class name (sidenav-circuit) again; theisolation/z-indexscaffolding the mask version needed is gone with it, sincebackground-imagecomposes directly.2. Bigger, centered product identity in the nav
The mark and wordmark were a 24px logo beside 15px text, left-aligned. They're now stacked and centered: 44px logo over a 20px wordmark. Stacking is what allows both to grow without widening the rail. Collapsed mode centers a 28px mark with the wordmark hidden, as before.
3. Data surfaces now sit a tone above the page
Root cause:
AppShell's main content area gainedbg-[color:var(--bg-1)]at some point afterv0.5.7, where it had been transparent over the shell's--bg-0. Every panel is also--bg-1, so panels ended up on a same-toned page with only their borders separating them — the flat look this fixes.Rather than reverting the page background (which would undo the newer rounded-card shell treatment), the data surfaces move up a tone. Applied in two passes, in this order, so nothing collided:
--bg-2elements inside those files →--bg-3. These are table header rows, badges and hover states; left alone they would have disappeared into the newly---bg-2panels around them.border+--bg-1) →--bg-2.Scope: 33 files across
src/features/**pluscomponents/data/StatCard.tsx.Deliberately excluded:
DropdownMenu,Pagination,EnvSwitcher,SideNavPreviewstay at--bg-1. A floating menu should read as elevated above the page, not sunk into it.LoginPage— the sweep initially caught it and the result was wrong. It's a standalone screen with its own cyber-grid and card-glow treatment, not a data surface on the app shell. Reverted.Changes
frontend/src/styles/base.css—.sidenav-circuitrestored fromv0.5.7frontend/src/components/chrome/SideNav.tsx— class name, stacked/centered identity at 44px + 20pxsrc/features/**andcomponents/data/StatCard.tsx— panel tone shiftTesting
tscclean.StatCard.test.tsxpinned the card surface to--bg-1. The test's actual intent is "flat surface, no decorative gradient", so the no-gradient assertion is untouched and only the token moved, with a comment recording why data surfaces sit above the page.Note for reviewers
Worth an eyeball in the browser before merging. The step is
#171717 → #1b1b1bin dark and#ffffff → #fcfcfcin light — intentionally gentle, but the light-theme delta is very subtle. If it reads as no change there, the fix is nudging the light--bg-2token a shade rather than revisiting 33 files.