Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code to restore the selection index after ItemsSourceProperty h… #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added code to restore the selection index after ItemsSourceProperty h… #6

wants to merge 2 commits into from

Conversation

geo-at-github
Copy link

…as been modified.

@joacar
Copy link
Owner

joacar commented Sep 14, 2018

Hi,

Thanks for contribution! Was some time ago, to say the least, when I viewed the source code.

Isn't there a risk of a cycle here where OnSelectedIndexChanged causes SelectedItemChanged which (might) raise OnSelectedIndexChanged? If you have time, perhaps you can include some units tests preferrable using xUnit

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geo-at-github @joacar