Fix Issue #1 - Changes to order of forms in Shopify's activate account page have broken mechanize_activate_customer_login.rb #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…account page have broken mechanize_activate_customer_login.rb To try and add a bit of resilience to future undocumented changes made by Shopify, the script will now loop through all the forms on the page, and identify the form which contains the 'password' fields. This will then assign the relevant form to the activate_form variable. While this solution is not completely bulletproof against future changes made by Shopify, it should mean that any future structural changes to that page will not break the mechanize script's functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #1 - Changes to order of forms in Shopify's activate account page have broken mechanize_activate_customer_login.rb
To try and add a bit of resilience to future undocumented changes made by Shopify, the script will now loop through all the forms on the page, and identify the form which contains the 'password' fields. This will then assign the relevant form to the
activate_formvariable.While this solution is not completely bulletproof against future changes made by Shopify, it should mean that any future structural changes to that page will not break the mechanize script's functionality.